Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing volume tagging #5519

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Fixing volume tagging #5519

merged 6 commits into from
Jan 17, 2024

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jan 12, 2024 •
edited
Loading

What problem does this PR solve?

Closes #5505

What is changed and how does it work?

  1. Add tags to valid PVs in the cluster
  2. Add tag of name of namespace
  3. Handle delete ratio unset issue for old backup

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot ti-chi-bot bot requested a review from lichunzhu January 12, 2024 13:01
@ti-chi-bot ti-chi-bot bot added the size/M label Jan 12, 2024
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @YuJuncen

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (197f1fe) 61.32% compared to head (6c56ed3) 61.39%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5519      +/-   ##
==========================================
+ Coverage   61.32%   61.39%   +0.07%     
==========================================
  Files         234      234              
  Lines       29996    29963      -33     
==========================================
+ Hits        18394    18396       +2     
+ Misses       9760     9735      -25     
+ Partials     1842     1832      -10
Flag Coverage Δ
unittest 61.39% <60.00%> (+0.07%) ⬆️

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/test-pull-e2e-kind

@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-16 06:24:46.776380717 +0000 UTC m=+250728.340678427: ☑️ agreed by WangLe1321.
  • 2024-01-16 14:39:56.603937607 +0000 UTC m=+280438.168235307: ✖️🔁 reset by BornChanger.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2024

New changes are detected. LGTM label has been removed.

@BornChanger BornChanger mentioned this pull request Jan 16, 2024
Open
@BornChanger
*: fix tagging to residule pv
e0b47a3 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: add missing tag
96ed7be 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: fix case
8d08276 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: address comments
6d30d05 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: fix tag for pod name space
b0f8b94 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: handle delete ratio for old backups
6c56ed3 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@csuzhangxc csuzhangxc merged commit a637f4c into pingcap:master Jan 17, 2024
5 of 6 checks passed
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5524.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 17, 2024
Merged
10 tasks
csuzhangxc pushed a commit that referenced this pull request Jan 17, 2024
@ti-chi-bot @BornChanger
Fixing volume tagging (#5519) (#5524)
227db87 
Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees
No one assigned
Labels
approved area/ebs-br size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BornChanger @codecov-commenter @ti-chi-bot @WangLe1321 @csuzhangxc